VItamin-and-Bilby-with-Different-Noises.md

@@ -101,7 +101,7 @@ ifos.set_strain_data_from_power_spectral_densities(
             sampling_frequency=sampling_frequency, duration=duration,
             start_time=ref_geocent_time-duration/2.0)     
 ```
-I think, my way of setting start time is Ok.    
+I think, my way of setting start time is also Ok here.    
 
 (iii) Priors are used differently. Priors used by tutorial are:(only different parts are shown)     
 ```
@@ -122,12 +122,16 @@ priors['geocent_time'] = bilby.core.prior.Uniform(
     maximum=ref_geocent_time + 1,
     name='geocent_time', latex_label='$t_c$', unit='$s$')     
 ```
-In this part, the additional specified priors are the correct format from Daniel. However, when I output priors, their distance priors are different:    
-> 'luminosity_distance': Uniform(minimum=1000, maximum=5000, name='luminosity_distance', latex_label='$d_L$', unit='$Mpc_{\\odot}$', boundary=None)    
-    
-> 'luminosity_distance': UniformSourceFrame(minimum=100.0, maximum=5000.0, cosmology=FlatLambdaCDM(name="Planck15", H0=67.7 km / (Mpc s), Om0=0.307, Tcmb0=2.725 K, Neff=3.05, m_nu=[0.   0.   0.06] eV, Ob0=0.0486), name='luminosity_distance', latex_label='$d_L$', unit=Unit("Mpc"), boundary=None)    
-    
-
+The prior of geocentric time are wider in my script. Besides, the additional specified priors are the correct format provided by Daniel. However, when I output priors, their distance priors are different.    
+Output of my script:    
+```
+'luminosity_distance': Uniform(minimum=1000, maximum=5000, name='luminosity_distance', latex_label='$d_L$', unit='$Mpc_{\\odot}$', boundary=None)    
+```
+Output of tutorial:     
+```
+'luminosity_distance': UniformSourceFrame(minimum=100.0, maximum=5000.0, cosmology=FlatLambdaCDM(name="Planck15", H0=67.7 km / (Mpc s), Om0=0.307, Tcmb0=2.725 K, Neff=3.05, m_nu=[0. 0. 0.06] eV, Ob0=0.0486), name='luminosity_distance', latex_label='$d_L$', unit=Unit("Mpc"), boundary=None)    
+```    
+I'm not sure if this has an impact when Bilby runs, though they point to the same range.      
 (iv) Result function.    
 Tutorial:    
 ```
@@ -143,6 +147,8 @@ result = bilby.run_sampler(
     likelihood=likelihood, priors=priors, sampler='dynesty', npoints=1000,
      outdir=outdir, label=label)     
 ```
+> generate_all_bbh_parameters function: From either a single sample or a set of samples fill in all missing BBH parameters in place.    
+
 ## (3) 15 parameters with (m1,m2) instead of (chirp mass, mass ratio)    
 We get results with good consistency in the sections above. This is to test if (m1,m2) will decrease the convergence.    
 ### (i) posterior    
@@ -175,6 +181,7 @@ JSD = 0.1759
 #### (a) distance     
 JSD = 0.1096    
 ![encounter_margil_d](uploads/81863c4571955f98fe5aa3f7d5112dba/encounter_margil_d.png)      
+Wrong template (using BBH template to model BH encounter) reduces the consistency of results.     
 ## (2) BH enoucnter without marginalization(distance, time, phase)     
 ### (i) posterior     
 ![encounter_without_margil](uploads/155ebf8256d4bdb4f3aeeab20a974c9b/encounter_without_margil.png)    
@@ -189,5 +196,5 @@ JSD = 0.4551
 #### (a) distance     
 JSD = 0.2937   
 ![encounter_d](uploads/1fd6439364cc2a2ba9fa6a061bf778e8/encounter_d.png)     
-
+Lack of Marginalization of distance, phase and time reduces the consistency of results further.     
      
\ No newline at end of file